netdev - Re: [PATCH v2] net/sctp/ulpevent.c: Deinline sctp_ulpevent_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 23 Jun 2017 17:39:18 -0300
From:   Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
To:     Denys Vlasenko <dvlasenk@...hat.com>
Cc:     linux-kernel@...r.kernel.org, Vlad Yasevich <vyasevich@...il.com>,
        Neil Horman <nhorman@...driver.com>,
        David Miller <davem@...emloft.net>, linux-sctp@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH v2] net/sctp/ulpevent.c: Deinline
 sctp_ulpevent_set_owner, save 1616 bytes

On Wed, Jun 21, 2017 at 07:03:27PM +0200, Denys Vlasenko wrote:
> This function compiles to 147 bytes of machine code. 13 callsites.
> 
> I'm no expert on SCTP events, but quick reading of SCTP docs tells me that
> SCTP events are not happening on every packet.
> They are ASSOC_CHANGE, PEER_ADDR_CHANGE, REMOTE_ERROR and such.
> Does not look performance critical.
> 
> Signed-off-by: Denys Vlasenko <dvlasenk@...hat.com>
> CC: Vlad Yasevich <vyasevich@...il.com>
> CC: Neil Horman <nhorman@...driver.com>
> CC: David Miller <davem@...emloft.net>
> CC: linux-sctp@...r.kernel.org
> CC: netdev@...r.kernel.org
> CC: linux-kernel@...r.kernel.org
> ---
> Changed since v1:
> * reindented function argument list

Dave, this patch is marked as Changes Requested on patchwork, but the v2
here looks good. There was no change request on it, only on the v1, and
they were satified on v2. The only info I asked on v2 was to know he had
a bigger plan for this, not sure if that's what caused confusion or not.

Thanks,
Marcelo