netdev - Re: [PATCH net] bnx2x: Don't log mc removal needlessly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170625.113439.249450058761462835.davem@davemloft.net>
Date:   Sun, 25 Jun 2017 11:34:39 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     Yuval.Mintz@...ium.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net] bnx2x: Don't log mc removal needlessly

From: Yuval Mintz <Yuval.Mintz@...ium.com>
Date: Sat, 24 Jun 2017 15:37:00 +0300

> When mc configuration changes bnx2x_config_mcast() can return 0 for
> success, negative for failure and positive for benign reason preventing
> its immediate work, e.g., when the command awaits the completion of
> a previously sent command.
> 
> When removing all configured macs on a 578xx adapter, if a positive
> value would be returned driver would errneously log it as an error.
> 
> Fixes: c7b7b483ccc9 ("bnx2x: Don't flush multicast MACs")
> Signed-off-by: Yuval Mintz <Yuval.Mintz@...ium.com>

Applied, thanks.