netdev - RE: [PATCH] net: Remove ndo_dfwd_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BLUPR0701MB2004CF8D2DC05A963F8548F88DDF0@BLUPR0701MB2004.namprd07.prod.outlook.com>
Date:   Mon, 26 Jun 2017 09:54:09 +0000
From:   "Mintz, Yuval" <Yuval.Mintz@...ium.com>
To:     David Miller <davem@...emloft.net>,
        "jasowang@...hat.com" <jasowang@...hat.com>,
        "john.fastabend@...il.com" <john.fastabend@...il.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH] net: Remove ndo_dfwd_start_xmit

> > Looks like commit f663dd9aaf9e ("net: core: explicitly select a txq
> > before doing l2 forwarding") has removed the need for this dedicated
> > xmit function [it even explicitly states so in its commit log message]
> > but it hasn't removed the definition of the ndo.
> >
> > Signed-off-by: Yuval Mintz <Yuval.Mintz@...ium.com>
> 
> Looks good, applied, thanks.

BTW, I've came across this while looking at ndo_dfwd_(add|del)_station,
but it Seems to me like there are simply not enough notification points to
reliably base the macvlan network-topology on in the offloader view.

Specifically, in case there is a mix of private/bridge macvlan instances
over a single lower-device, I can't see how the offloader could know and
prevent packets from being internally routed to the private instances.

Could someone perhaps clarify it a bit?