netdev - Re: [PATCH net-next v2 4/5] net: add netlink_ext_ack argument to rtnl_link_ops.slave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bb1892a4-2227-cdc4-e017-f39f133fd20a@universe-factory.net>
Date:   Mon, 26 Jun 2017 15:45:31 +0200
From:   Matthias Schiffer <mschiffer@...verse-factory.net>
To:     David Ahern <dsahern@...il.com>, dledford@...hat.com,
        sean.hefty@...el.com, hal.rosenstock@...il.com,
        j.vosburgh@...il.com, vfalico@...il.com, andy@...yhouse.net,
        wg@...ndegger.com, mkl@...gutronix.de, pablo@...filter.org,
        laforge@...monks.org, paulus@...ba.org, jiri@...nulli.us,
        dsa@...ulusnetworks.com, shm@...ulusnetworks.com,
        davem@...emloft.net, stephen@...workplumber.org,
        arvid.brodin@...en.se, alex.aring@...il.com,
        stefan@....samsung.com, kuznet@....inr.ac.ru, jmorris@...ei.org,
        yoshfuji@...ux-ipv6.org, kaber@...sh.net,
        steffen.klassert@...unet.com, herbert@...dor.apana.org.au,
        johannes@...solutions.net
Cc:     linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, linux-can@...r.kernel.org,
        linux-ppp@...r.kernel.org, linux-wpan@...r.kernel.org
Subject: Re: [PATCH net-next v2 4/5] net: add netlink_ext_ack argument to
 rtnl_link_ops.slave_changelink

On 06/26/2017 03:33 PM, David Ahern wrote:
> On 6/26/17 2:43 AM, Matthias Schiffer wrote:
>> On 06/26/2017 06:08 AM, David Ahern wrote:
>>> On 6/25/17 10:04 PM, David Ahern wrote:
>>>> On 6/25/17 3:56 PM, Matthias Schiffer wrote:
>>>>> Add support for extended error reporting.
>>>>>
>>>>> Signed-off-by: Matthias Schiffer <mschiffer@...verse-factory.net>
>>>>> ---
>>>>
>>>>
>>>> Acked-by: David Ahern <dsahern@...il.com>
>>>>
>>>
>>> Actually, you are missing the chagne to br_port_slave_changelink.
>>>
>>
>> I'm confused. I am changing br_port_slave_changelink? All my patches are
>> compile-tested.
>>
> 
> You are changing the signature of slave_changelink, no?
> 
> net/bridge/br_netlink.c:
>         .slave_changelink       = br_port_slave_changelink,
> 


Please read my patch again, I *am* changing br_port_slave_changelink to
match the new signature (this is the net/bridge/br_netlink.c change
appearing in the diffstat).



Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)