netdev - Re: [PATCH net-next 2/3] cxgb4: core hardware/firmware support for Forward Error Correction on a link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 26 Jun 2017 23:16:56 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     roopa@...ulusnetworks.com
Cc:     linville@...driver.com, netdev@...r.kernel.org,
        vidya.chowdary@...il.com, dustin@...ulusnetworks.com,
        olson@...ulusnetworks.com, leedom@...lsio.com,
        manojmalviya@...lsio.com, santosh@...lsio.com,
        yuval.mintz@...gic.com, odedw@...lanox.com, ariela@...lanox.com,
        galp@...lanox.com, jeffrey.t.kirsher@...el.com
Subject: Re: [PATCH net-next 2/3] cxgb4: core hardware/firmware support for
 Forward Error Correction on a link

From: Roopa Prabhu <roopa@...ulusnetworks.com>
Date: Sat, 24 Jun 2017 12:19:44 -0700

> @@ -3690,11 +3690,64 @@ void t4_ulprx_read_la(struct adapter *adap, u32 *la_buf)
>  		     FW_PORT_CAP_SPEED_40G | FW_PORT_CAP_SPEED_100G | \
>  		     FW_PORT_CAP_ANEG)
>  
> +/* Translate Firmware Port Capabilities Pause specification to Common Code */
> +static inline unsigned int fwcap_to_cc_pause(unsigned int fw_pause)
> +{

Do not use "inline" in foo.c files, always let the compiler decide.

Same goes for patch #3.