netdev - Re: [PATCH 1/1] tc: custom qdisc pkt size translation table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAA0ESdrH+_1OhkuL7wmjjM-zNqY0o4qp5qDdfrNCR9LENCqbQQ@mail.gmail.com>
Date:   Tue, 27 Jun 2017 12:37:40 -0500
From:   Robert McCabe <robert.mccabe@...kwellcollins.com>
To:     netdev@...r.kernel.org
Subject: Re: [PATCH 1/1] tc: custom qdisc pkt size translation table

Yeah, sorry didn't even think about that.
I guess my first question would be is there another way via the
iproute2 project where a user could
configure the stab->data pkt size translation table used in the
__qdisc_calculate_pkt_len method
in the kernel source (net/sched/sched_api.c)?

Also, let's say I went ahead and made the added TC_LINK_LAYER_CUSTOM
to the include/uapi/linux/pkt_sched.h
file in the kernel source ... would I also need to make the same
change in include/uapi/linux/pkt_sched.h in
the iproute2 source?

Do you recommend an alternative (more elegant) approach to what I'm
trying to accomplish?


On Tue, Jun 27, 2017 at 11:55 AM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> On Tue, 2017-06-27 at 11:29 -0500, McCabe, Robert J wrote:
>> Added the "custom" linklayer qdisc stab option.
>> This allows the user to specify the pkt size translation
>> parameters from stdin.
>> Example:
>>    tc qdisc add ... stab tsize 8 linklayer custom htb
>>    Custom size table:
>>    InputSizeStart -> IntputSizeEnd: Output Pkt Size
>>    0 - 255: 400
>>    256 - 511: 800
>>    512 - 767: 1200
>>    768 - 1023: 1600
>>    1024 - 1279: 2000
>>    1280 - 1535: 2400
>>    1536 - 1791: 2800
>>    1792 - 2047: 3200
>>
>> Signed-off-by: McCabe, Robert J <Robert.McCabe@...kwellcollins.com>
>> ---
>>  include/linux/pkt_sched.h |  1 +
>>  tc/tc_core.c              | 51 +++++++++++++++++++++++++++++++++++++++++++++++
>>  tc/tc_core.h              |  2 +-
>>  tc/tc_stab.c              |  4 +++-
>>  tc/tc_util.c              |  5 +++++
>>  5 files changed, 61 insertions(+), 2 deletions(-)
>>
>> diff --git a/include/linux/pkt_sched.h b/include/linux/pkt_sched.h
>> index 099bf55..289bb81 100644
>> --- a/include/linux/pkt_sched.h
>> +++ b/include/linux/pkt_sched.h
>> @@ -82,6 +82,7 @@ enum tc_link_layer {
>>       TC_LINKLAYER_UNAWARE, /* Indicate unaware old iproute2 util */
>>       TC_LINKLAYER_ETHERNET,
>>       TC_LINKLAYER_ATM,
>> +     TC_LINKLAYER_CUSTOM,
>>  };
>>  #define TC_LINKLAYER_MASK 0x0F /* limit use to lower 4 bits */
>>
>
>
> You can not do this : This file is coming from the kernel
> ( include/uapi/linux/pkt_sched.h )
>
> Since your patch is user space only, you need to find another way ?
>
>
>