netdev - Re: [net-next 6/6] ixgbe: Add malicious driver detection support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170626.232619.984190800113889312.davem@davemloft.net>
Date:   Mon, 26 Jun 2017 23:26:19 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     jeffrey.t.kirsher@...el.com
Cc:     paul.greenwalt@...el.com, netdev@...r.kernel.org,
        nhorman@...hat.com, sassmann@...hat.com, jogreene@...hat.com
Subject: Re: [net-next 6/6] ixgbe: Add malicious driver detection support

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Mon, 26 Jun 2017 14:39:33 -0700

> +		if ((adapter->num_vfs) && (hw->mac.ops.disable_mdd) &&

Excessive parenthesis.

> +		if ((adapter->num_vfs) && (hw->mac.ops.enable_mdd) &&

Likewise.

> +	if ((adapter->num_vfs) && (hw->mac.ops.disable_mdd) &&

Likewise.

> +	if ((adapter->num_vfs) && (hw->mac.ops.enable_mdd) &&

Likewise.

> +	/* Turn on malicious driver detection */
> +	if ((adapter->num_vfs) && (hw->mac.ops.enable_mdd) &&

Likewise.

> +	/* Turn off malicious driver detection */
> +	if ((hw->mac.ops.disable_mdd) &&

Likewise.