netdev - Re: [PATCH net-next] tcp: fix null ptr deref in getsockopt(..., TCP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170627.153927.140891706842589227.davem@davemloft.net>
Date:   Tue, 27 Jun 2017 15:39:27 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     davejwatson@...com
Cc:     ilyal@...lanox.com, aviadye@...lanox.com, borisp@...lanox.com,
        alexander.levin@...izon.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] tcp: fix null ptr deref in getsockopt(...,
 TCP_ULP, ...)

From: Dave Watson <davejwatson@...com>
Date: Mon, 26 Jun 2017 08:36:47 -0700

> If icsk_ulp_ops is unset, it dereferences a null ptr.
> Add a null ptr check.
> 
> BUG: KASAN: null-ptr-deref in copy_to_user include/linux/uaccess.h:168 [inline]
> BUG: KASAN: null-ptr-deref in do_tcp_getsockopt.isra.33+0x24f/0x1e30 net/ipv4/tcp.c:3057
> Read of size 4 at addr 0000000000000020 by task syz-executor1/15452
> 
> Signed-off-by: Dave Watson <davejwatson@...com>
> Reported-by: "Levin, Alexander (Sasha Levin)" <alexander.levin@...izon.com>

Applied, thanks.