netdev - Re: [Intel-wired-lan] [PATCH v2 1/1] e1000e: Undo e1000e_pm_freeze if __e1000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1498596665.3244.2.camel@intel.com>
Date:   Tue, 27 Jun 2017 13:51:05 -0700
From:   Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:     Dave Airlie <airlied@...il.com>,
        "Brown, Aaron F" <aaron.f.brown@...el.com>,
        David Miller <davem@...emloft.net>,
        "Nikula, Jani" <jani.nikula@...el.com>,
        "Ursulin, Tvrtko" <tvrtko.ursulin@...el.com>,
        "intel-gfx@...ts.freedesktop.org" <intel-gfx@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "jani.nikula@...ux.intel.com" <jani.nikula@...ux.intel.com>,
        "chris@...is-wilson.co.uk" <chris@...is-wilson.co.uk>,
        "Ertman, David M" <david.m.ertman@...el.com>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Cc:     "daniel.vetter@...ll.ch" <daniel.vetter@...ll.ch>
Subject: Re: [Intel-wired-lan] [PATCH v2 1/1] e1000e: Undo e1000e_pm_freeze
 if __e1000_shutdown fails

On Wed, 2017-06-28 at 05:28 +1000, Dave Airlie wrote:
> On 20 June 2017 at 18:49, Daniel Vetter <daniel@...ll.ch> wrote:
> > On Wed, Jun 07, 2017 at 01:07:33AM +0000, Brown, Aaron F wrote:
> > > > From: Intel-wired-lan [mailto:intel-wired-lan-bounces@...osl.org]
> > > > On Behalf
> > > > Of Jeff Kirsher
> > > > Sent: Tuesday, June 6, 2017 1:46 PM
> > > > To: David Miller <davem@...emloft.net>; Nikula, Jani
> > > > <jani.nikula@...el.com>
> > > > Cc: Ursulin, Tvrtko <tvrtko.ursulin@...el.com>; daniel.vetter@...ll
> > > > .ch; intel-
> > > > gfx@...ts.freedesktop.org; linux-kernel@...r.kernel.org;
> > > > jani.nikula@...ux.intel.com; chris@...is-wilson.co.uk; Ertman,
> > > > David M
> > > > <david.m.ertman@...el.com>; intel-wired-lan@...ts.osuosl.org; dri-
> > > > devel@...ts.freedesktop.org; netdev@...r.kernel.org; airlied@...il.
> > > > com
> > > > Subject: Re: [Intel-wired-lan] [PATCH v2 1/1] e1000e: Undo
> > > > e1000e_pm_freeze if __e1000_shutdown fails
> > > > 
> > > > On Fri, 2017-06-02 at 14:14 -0400, David Miller wrote:
> > > > > From: Jani Nikula <jani.nikula@...el.com>
> > > > > Date: Wed, 31 May 2017 18:50:43 +0300
> > > > > 
> > > > > > From: Chris Wilson <chris@...is-wilson.co.uk>
> > > > > > 
> > > > > > An error during suspend (e100e_pm_suspend),
> > > > > 
> > > > >  ...
> > > > > > lead to complete failure:
> > > > > 
> > > > >  ...
> > > > > > The unwind failures stems from commit 2800209994f8 ("e1000e:
> > > > > > Refactor PM
> > > > > > flows"), but it may be a later patch that introduced the non-
> > > > > > recoverable
> > > > > > behaviour.
> > > > > > 
> > > > > > Fixes: 2800209994f8 ("e1000e: Refactor PM flows")
> > > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99847
> > > > > > Cc: Tvrtko Ursulin <tvrtko.ursulin@...el.com>
> > > > > > Cc: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> > > > > > Cc: Dave Ertman <davidx.m.ertman@...el.com>
> > > > > > Cc: Bruce Allan <bruce.w.allan@...el.com>
> > > > > > Cc: intel-wired-lan@...ts.osuosl.org
> > > > > > Cc: netdev@...r.kernel.org
> > > > > > Signed-off-by: Chris Wilson <chris@...is-wilson.co.uk>
> > > > > > [Jani: bikeshed repainted]
> > > > > > Signed-off-by: Jani Nikula <jani.nikula@...el.com>
> > > > > 
> > > > > Jeff, please make sure this gets submitted to me soon.
> > > > 
> > > > Expect it later tonight, just finishing up testing.
> > > 
> > > Tested-by: Aaron Brown <aaron.f.brown@...el.com>
> > 
> > Hm, I seem to be blind, but I can't find it anywhere in -rc6. Does
> > someone
> > have the sha1 from Linus' git for this patch?
> 
> Guys this is a pretty serious regression, just left blowing in the
> wind, is anyone responsible for e1000e?

This was submitted and accepted into David Miller's net-next tree.  I can
see if Dave can pull it into his net tree.  DOes stable need to pick this
up as well?
Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)