netdev - Re: [RFC 01/19] qed: Introduce iWARP personality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170627053635.GM1248@mtr-leonro.local>
Date:   Tue, 27 Jun 2017 08:36:35 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Michal Kalderon <Michal.Kalderon@...ium.com>
Cc:     ram.amrani@...ium.com, yuval.mintz@...ium.com,
        ariel.elior@...ium.com, davem@...emloft.net,
        netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
        dledford@...hat.com
Subject: Re: [RFC 01/19] qed: Introduce iWARP personality

On Mon, Jun 26, 2017 at 09:06:51PM +0300, Michal Kalderon wrote:
> iWARP personality introduced the need for differentiating in several
> places in the code whether we are RoCE, iWARP or either. This
> leads to introducing new macros for querying the personality.
>
> Signed-off-by: Michal Kalderon <Michal.Kalderon@...ium.com>
> Signed-off-by: Yuval Mintz <Yuval.Mintz@...ium.com>
> Signed-off-by: Ariel Elior <Ariel.Elior@...ium.com>
>
> ---
>  drivers/net/ethernet/qlogic/qed/qed.h      | 26 +++++++++++++++++++++++---
>  drivers/net/ethernet/qlogic/qed/qed_cxt.c  |  8 ++++----
>  drivers/net/ethernet/qlogic/qed/qed_dev.c  | 12 +++++-------
>  drivers/net/ethernet/qlogic/qed/qed_l2.c   |  3 +--
>  drivers/net/ethernet/qlogic/qed/qed_ll2.c  |  2 +-
>  drivers/net/ethernet/qlogic/qed/qed_main.c | 17 ++++++++---------
>  include/linux/qed/common_hsi.h             |  2 +-
>  7 files changed, 43 insertions(+), 27 deletions(-)

I see that these changes are in Ethernet part of your driver, but for
RDMA part, there are already available inline functions:
rdma_protocol_iwarp, rdma_protocol_roce.

Please avoid introducing new IS_IWARP/IS_ROCE macros and the decision
should be taken on port level and not on device, despite the fact that
probably your ib_device has only one port.

Thanks

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)