netdev - RE: [RFC 15/19] RDMA/qedr: Add iWARP support in existing verbs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM2PR0701MB13924E652A0F1970BE3ECD5788DC0@DM2PR0701MB1392.namprd07.prod.outlook.com>
Date:   Tue, 27 Jun 2017 08:18:02 +0000
From:   "Kalderon, Michal" <Michal.Kalderon@...ium.com>
To:     Leon Romanovsky <leon@...nel.org>
CC:     "Amrani, Ram" <Ram.Amrani@...ium.com>,
        "Mintz, Yuval" <Yuval.Mintz@...ium.com>,
        "Elior, Ariel" <Ariel.Elior@...ium.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "dledford@...hat.com" <dledford@...hat.com>
Subject: RE: [RFC 15/19] RDMA/qedr: Add iWARP support in existing verbs.

From: Leon Romanovsky [mailto:leon@...nel.org]
Sent: Tuesday, June 27, 2017 8:27 AM
 
> On Mon, Jun 26, 2017 at 09:07:05PM +0300, Michal Kalderon wrote:
> > Make slight modifications to common RoCE/iWARP code.
> > Add additional doorbell for iWARP post_send.
> > iWARP QP pbl is allocated in qed and not in qedr.
> >
> > Signed-off-by: Michal Kalderon <Michal.Kalderon@...ium.com>
> > Signed-off-by: Ram Amrani <Ram.Amrani@...ium.com>
> > Signed-off-by: Ariel Elior <Ariel.Elior@...ium.com>
> >
> > ---
> >  drivers/infiniband/hw/qedr/qedr.h  |   3 +
> >  drivers/infiniband/hw/qedr/verbs.c | 171
> +++++++++++++++++++++++++++++--------
> >  2 files changed, 139 insertions(+), 35 deletions(-)
> >
> > diff --git a/drivers/infiniband/hw/qedr/qedr.h
> b/drivers/infiniband/hw/qedr/qedr.h
> > index c52fde0..0c0a39a 100644
> > --- a/drivers/infiniband/hw/qedr/qedr.h
> > +++ b/drivers/infiniband/hw/qedr/qedr.h
> > @@ -319,6 +319,9 @@ struct qedr_qp_hwq_info {
> >  	/* DB */
> >  	void __iomem *db;
> >  	union db_prod32 db_data;
> > +
> > +	void __iomem *iwarp_db2;
> > +	union db_prod32 iwarp_db2_data;
> 
> Why do you need two doorbells?

This is a hw requirement to handle error state in iWARP 
> >  };