netdev - Re: [net-next v2 6/6] ixgbe: Add malicious driver detection support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ3xEMiEjGDUatUv47wNTfYPfCVo62+Jjs-xFU3ccN0iJm-5Gg@mail.gmail.com>
Date:   Tue, 27 Jun 2017 12:07:43 +0300
From:   Or Gerlitz <gerlitz.or@...il.com>
To:     Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:     David Miller <davem@...emloft.net>,
        Paul Greenwalt <paul.greenwalt@...el.com>,
        Linux Netdev List <netdev@...r.kernel.org>,
        "nhorman@...hat.com" <nhorman@...hat.com>,
        "sassmann@...hat.com" <sassmann@...hat.com>,
        "jogreene@...hat.com" <jogreene@...hat.com>
Subject: Re: [net-next v2 6/6] ixgbe: Add malicious driver detection support

On Tue, Jun 27, 2017 at 11:51 AM, Jeff Kirsher
<jeffrey.t.kirsher@...el.com> wrote:
> From: Paul Greenwalt <paul.greenwalt@...el.com>
>
> Add malicious driver detection (MDD) support for X550, X550em_a,
> and X550em_x devices.
>
> MDD is a hardware SR-IOV security feature which the driver enables by
> default, but can be controlled on|off by ethtool set-priv-flags

wait, we have the trusted vf concept, which you implement
(ixgbe_ndo_set_vf_trust)
so you can enable by default for all vfs and disable it for trusted
ones, why create
an ixgbe special config knob? IMHO we should max all possible efforts to avoid
priv ethtool flags usage.


Or.