netdev - Re: [oss-drivers] Re: [PATCH/RFC net-next 4/9] nfp: extend flower add flow offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 28 Jun 2017 10:13:49 +0200
From:   Simon Horman <simon.horman@...ronome.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        oss-drivers@...ronome.com,
        Pieter Jansen van Vuuren 
        <pieter.jansenvanvuuren@...ronome.com>
Subject: Re: [oss-drivers] Re: [PATCH/RFC net-next 4/9] nfp: extend flower
 add flow offload

On Tue, Jun 27, 2017 at 11:13:30PM -0700, Jakub Kicinski wrote:
> On Wed, 28 Jun 2017 01:21:44 +0200, Simon Horman wrote:
> > diff --git a/drivers/net/ethernet/netronome/nfp/flower/offload.c b/drivers/net/ethernet/netronome/nfp/flower/offload.c
> > index 9127c28ea9c3..8ad72f57493d 100644
> > --- a/drivers/net/ethernet/netronome/nfp/flower/offload.c
> > +++ b/drivers/net/ethernet/netronome/nfp/flower/offload.c
> > @@ -45,6 +45,145 @@
> >  #include "../nfp_net.h"
> >  #include "../nfp_port.h"
> >  
> > +static bool nfp_flower_check_lower_than_mac(struct tc_cls_flower_offload *f)
> > +{
> > +	return dissector_uses_key(f->dissector,
> > +				  FLOW_DISSECTOR_KEY_IPV4_ADDRS) ||
> > +		dissector_uses_key(f->dissector,
> > +				   FLOW_DISSECTOR_KEY_IPV6_ADDRS) ||
> > +		dissector_uses_key(f->dissector,
> > +				   FLOW_DISSECTOR_KEY_PORTS) ||
> > +		dissector_uses_key(f->dissector, FLOW_DISSECTOR_KEY_ICMP);
> > +}
> 
> Nit: should this be named higher than mac?

Yes, I think so now you mention it.
I'll fix this in v2.