netdev - Re: [PATCH 2/2] ethtool: stmmac: Add DMA HW Feature Register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1e300373-cacf-6630-a6fe-6014d58940a9@linux.intel.com>
Date:   Wed, 28 Jun 2017 08:25:14 -0500
From:   Thor Thayer <thor.thayer@...ux.intel.com>
To:     Giuseppe CAVALLARO <peppe.cavallaro@...com>, linville@...driver.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] ethtool: stmmac: Add DMA HW Feature Register

On 06/28/2017 04:03 AM, Giuseppe CAVALLARO wrote:
> On 6/27/2017 11:51 PM, thor.thayer@...ux.intel.com wrote:
>> From: Thor Thayer <thor.thayer@...ux.intel.com>
>>
>> This patch adds the DMA HW Feature Register which is at the end
>> of the DMA registers and is documented in Version 3.70a.
>>
>> Signed-off-by: Thor Thayer <thor.thayer@...ux.intel.com>
>> ---
>>   stmmac.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/stmmac.c b/stmmac.c
>> index e1bb291..7d7bebd 100644
>> --- a/stmmac.c
>> +++ b/stmmac.c
>> @@ -64,7 +64,7 @@ int st_gmac_dump_regs(struct ethtool_drvinfo *info, 
>> struct ethtool_regs *regs)
>>       fprintf(stdout, "\n");
>>       fprintf(stdout, "DMA Registers\n");
>>       stmmac_reg = (unsigned int *)regs->data + DMA_REG_OFFSET;
>> -    for (i = 0; i < 22; i++)
>> +    for (i = 0; i < 23; i++)
> 
> thx Thor for these changes, I wonder if you could add a macro instead 23 
> while doing this kind of changes
> 
> Sorry if I didn't it in the past.
> 
> the, you can send the series with my Acked-by: Giuseppe Cavallaro 
> <peppe.cavallaro@...com>
> 
> Regards
> 
> peppe
> 

Sure. I'll also add a macro for the # of main registers too (55). Some 
maintainers prefer the macros while others prefer the number to reduce 
the space.

Thanks for the quick review!

Thor
> 
>>           fprintf(stdout, "Reg%d  0x%08X\n", i, *stmmac_reg++);
>>       return 0;
> 
> 
>