netdev - Re: [PATCH net] mlxsw: spectrum_router: Fix NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170629.130018.1205616246799157439.davem@davemloft.net>
Date:   Thu, 29 Jun 2017 13:00:18 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     idosch@...lanox.com
Cc:     netdev@...r.kernel.org, jiri@...lanox.com, petrm@...lanox.com,
        mlxsw@...lanox.com
Subject: Re: [PATCH net] mlxsw: spectrum_router: Fix NULL pointer
 dereference

From: Ido Schimmel <idosch@...lanox.com>
Date: Wed, 28 Jun 2017 09:03:12 +0300

> In case a VLAN device is enslaved to a bridge we shouldn't create a
> router interface (RIF) for it when it's configured with an IP address.
> This is already handled by the driver for other types of netdevs, such
> as physical ports and LAG devices.
> 
> If this IP address is then removed and the interface is subsequently
> unlinked from the bridge, a NULL pointer dereference can happen, as the
> original 802.1d FID was replaced with an rFID which was then deleted.
> 
> To reproduce:
> $ ip link set dev enp3s0np9 up
> $ ip link add name enp3s0np9.111 link enp3s0np9 type vlan id 111
> $ ip link set dev enp3s0np9.111 up
> $ ip link add name br0 type bridge
> $ ip link set dev br0 up
> $ ip link set enp3s0np9.111 master br0
> $ ip address add dev enp3s0np9.111 192.168.0.1/24
> $ ip address del dev enp3s0np9.111 192.168.0.1/24
> $ ip link set dev enp3s0np9.111 nomaster
> 
> Fixes: 99724c18fc66 ("mlxsw: spectrum: Introduce support for router interfaces")
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>
> Reported-by: Petr Machata <petrm@...lanox.com>
> Tested-by: Petr Machata <petrm@...lanox.com>
> Reviewed-by: Petr Machata <petrm@...lanox.com>

Applied and queued up for -stable, thanks.