netdev - Re: kernel (master) build failure w. !CONFIG_NET_RX_BUSY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170629.153527.1327069677943074079.davem@davemloft.net>
Date:   Thu, 29 Jun 2017 15:35:27 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     efault@....de
Cc:     netdev@...r.kernel.org, linux-rt-users@...r.kernel.org
Subject: Re: kernel (master) build failure w. !CONFIG_NET_RX_BUSY_POLL

From: Mike Galbraith <efault@....de>
Date: Wed, 28 Jun 2017 10:01:00 +0200

> Greetings network wizards,
> 
> The latest RT explicitly disables CONFIG_NET_RX_BUSY_POLL, thus
> uncovering $subject.  Below is what I did about it.
> 
> 	-Mike
> 
> net: Move napi_hash_add/del() inside CONFIG_NET_RX_BUSY_POLL
> 
> Since 545cd5e5ec54 ("net: Busy polling should ignore sender CPUs"),
> kernel build fails when CONFIG_NET_RX_BUSY_POLL is disabled.  Move
> napi_hash_add/del() accordingly.
> 
> Banged-upon-by: Mike Galbraith <efault@....de>

First, this is in no way a standard signoff or ack tag.

Second, you must provide the complete set of build failure details
so that anyone just reading your posting can understand and fully
review your patch without having to go anywhere else for the
pertinent information.

And, lastly, I can't see how anything like this could be necessary
with the way the code is currently structures in the 'net' tree.  This
is really why you need to make a full report, with build failure
messages, as well as an explanation of what your change does, and why
it does it that way.

Thanks.