netdev - Re: [PATCH net-next] ibmvnic: Fix assignment of RX/TX IRQ's

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170629.154419.1976803371578783974.davem@davemloft.net>
Date:   Thu, 29 Jun 2017 15:44:19 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     tlfalcon@...ux.vnet.ibm.com
Cc:     netdev@...r.kernel.org, jallen@...ux.vnet.ibm.com,
        nfont@...ux.vnet.ibm.com
Subject: Re: [PATCH net-next] ibmvnic: Fix assignment of RX/TX IRQ's

From: Thomas Falcon <tlfalcon@...ux.vnet.ibm.com>
Date: Wed, 28 Jun 2017 19:55:54 -0500

> The driver currently creates RX/TX queues during device probe, but
> assigns IRQ's to them during device open. On reset, however,
> IRQ's are assigned when resetting the queues. If there is a reset
> while the device is closed and the device is later opened, the driver will
> request IRQ's twice, causing the open to fail. This patch assigns
> the IRQ's in the ibmvnic_init function after the queues are reset or
> initialized, ensuring IRQ's are only requested once.
> 
> Signed-off-by: Thomas Falcon <tlfalcon@...ux.vnet.ibm.com>

Applied, thanks Thomas.