netdev - Re: [PATCH] net: bridge: constify attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170629.155004.847683681702714728.davem@davemloft.net>
Date:   Thu, 29 Jun 2017 15:50:04 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     arvind.yadav.cs@...il.com
Cc:     stephen@...workplumber.org, bridge@...ts.linux-foundation.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: bridge: constify attribute_group structures.

From: Arvind Yadav <arvind.yadav.cs@...il.com>
Date: Thu, 29 Jun 2017 16:39:38 +0530

> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work with const
> attribute_group. So mark the non-const structs as const.
> 
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>    2645	    896	      0	   3541	    dd5	net/bridge/br_sysfs_br.o
> 
> File size After adding 'const':
>    text	   data	    bss	    dec	    hex	filename
>    2701	    832	      0	   3533	    dcd	net/bridge/br_sysfs_br.o
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Applied.