netdev - Re: [PATCH net] sfc: fix attempt to translate invalid filter ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 29 Jun 2017 16:02:45 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     ecree@...arflare.com
Cc:     linux-net-drivers@...arflare.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] sfc: fix attempt to translate invalid filter ID

From: Edward Cree <ecree@...arflare.com>
Date: Thu, 29 Jun 2017 16:50:06 +0100

> When filter insertion fails with no rollback, we were trying to convert
>  EFX_EF10_FILTER_ID_INVALID to an id to store in 'ids' (which is either
>  vlan->uc or vlan->mc).  This would WARN_ON_ONCE and then record a bogus
>  filter ID of 0x1fff, neither of which is a good thing.
> 
> Fixes: 0ccb998bf46d ("sfc: fix filter_id misinterpretation in edge case")
> Signed-off-by: Edward Cree <ecree@...arflare.com>

Applied, thanks.