netdev - Re: [PATCH net-next v4 04/16] bpf: Sample bpf program to set SYN/SYN-ACK RTOs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <43F29BF4-8847-47AC-AE0F-9FC9410B7D5C@fb.com>
Date:   Thu, 29 Jun 2017 22:25:36 +0000
From:   Lawrence Brakmo <brakmo@...com>
To:     Jesper Dangaard Brouer <brouer@...hat.com>
CC:     netdev <netdev@...r.kernel.org>, Kernel Team <Kernel-team@...com>,
        "Blake Matheny" <bmatheny@...com>, Alexei Starovoitov <ast@...com>,
        Daniel Borkmann <daniel@...earbox.net>,
        David Ahern <dsa@...ulusnetworks.com>
Subject: Re: [PATCH net-next v4 04/16] bpf: Sample bpf program to set
 SYN/SYN-ACK RTOs


On 6/29/17, 12:39 PM, "netdev-owner@...r.kernel.org on behalf of Jesper Dangaard Brouer" <netdev-owner@...r.kernel.org on behalf of brouer@...hat.com> wrote:

    On Wed, 28 Jun 2017 10:31:12 -0700
    Lawrence Brakmo <brakmo@...com> wrote:
    
    > +++ b/samples/bpf/tcp_synrto_kern.c
    > @@ -0,0 +1,60 @@
    > +/* Copyright (c) 2017 Facebook
    > + *
    > + * This program is free software; you can redistribute it and/or
    > + * modify it under the terms of version 2 of the GNU General Public
    > + * License as published by the Free Software Foundation.
    > + *
    > + * BPF program to set SYN and SYN-ACK RTOs to 10ms when using IPv6 addresses
    > + * and the first 5.5 bytes of the IPv6 addresses are the same (in this example
    > + * that means both hosts are in the same datacenter.
    
    Missing end ")".
    
    I really like this short comment of what the program does, as it helps
    people browsing these sample programs. 
    
    Can you also mention in the comment (of all these) bpf programs that
    people load this bpf object file via the program 'load_sock_ops'?

Thank you for finding the typo and for the comment on adding how to load the sample programs. Will be done in v5 due later today.
    
    -- 
    Best regards,
      Jesper Dangaard Brouer
      MSc.CS, Principal Kernel Engineer at Red Hat
      LinkedIn: https://urldefense.proofpoint.com/v2/url?u=http-3A__www.linkedin.com_in_brouer&d=DwICAg&c=5VD0RTtNlTh3ycd41b3MUw&r=pq_Mqvzfy-C8ltkgyx1u_g&m=EJ1TyanCGEOIXEPnAm8BicVjUXEJLsvUQY1vNC_4r7g&s=INcdT-mimhOZEgFLw7hqg2V6VJ70XZJoeY83vp6V8YY&e=