netdev - Re: [PATCH net-next v2 4/9] nfp: extend flower add flow offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170628234829.76098a18@cakuba.netronome.com>
Date:   Wed, 28 Jun 2017 23:48:29 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Yunsheng Lin <linyunsheng@...wei.com>
Cc:     Simon Horman <simon.horman@...ronome.com>,
        David Miller <davem@...emloft.net>, <netdev@...r.kernel.org>,
        <oss-drivers@...ronome.com>,
        "Pieter Jansen van Vuuren" <pieter.jansenvanvuuren@...ronome.com>
Subject: Re: [PATCH net-next v2 4/9] nfp: extend flower add flow offload

On Thu, 29 Jun 2017 14:18:07 +0800, Yunsheng Lin wrote:
> > +	if (mask_basic->n_proto) {  
> cpu_to_be16（mask_basic->n_proto）
> remove cpu_to_be16 in case.

Thanks, but this is incorrect.  Byte swapping constants is done at
compilation time - therefore it's preferred.