netdev - Re: [PATCH net-next v2 3/9] nfp: provide infrastructure for offloading flower based TC filters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170629081652.GE29453@vergenet.net>
Date:   Thu, 29 Jun 2017 10:16:54 +0200
From:   Simon Horman <simon.horman@...ronome.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        oss-drivers@...ronome.com,
        Pieter Jansen van Vuuren 
        <pieter.jansenvanvuuren@...ronome.com>
Subject: Re: [PATCH net-next v2 3/9] nfp: provide infrastructure for
 offloading flower based TC filters

On Wed, Jun 28, 2017 at 06:53:40PM -0700, Jakub Kicinski wrote:
> On Wed, 28 Jun 2017 22:29:56 +0200, Simon Horman wrote:
> > +/**
> > + * nfp_flower_del_offload() - Removes a flow from hardware.
> > + * @app:	Pointer to the APP handle
> > + * @netdev:	netdev structure.
> > + * @flow:       TC flower classifier offload structure
> 
> Nit: there are spaces and tabs mixed here, same for
> nfp_flower_get_stats().

Thanks for noticing that, we'll fix it.

> > + *
> > + * Removes a flow from the repeated hash structure and clears the
> > + * action payload.
> > + *
> > + * Return: negative value on error, 0 if removed successfully.
> > + */
> > +static int
> > +nfp_flower_del_offload(struct nfp_app *app, struct net_device *netdev,
> > +		       struct tc_cls_flower_offload *flow)
> > +{
> > +	return -EOPNOTSUPP;
> > +}
>