[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <063D6719AE5E284EB5DD2968C1650D6DD002DCAB@AcuExch.aculab.com>
Date: Thu, 29 Jun 2017 14:45:15 +0000
From: David Laight <David.Laight@...LAB.COM>
To: 'Or Gerlitz' <gerlitz.or@...il.com>,
Simon Horman <simon.horman@...ronome.com>
CC: David Miller <davem@...emloft.net>,
Jakub Kicinski <jakub.kicinski@...ronome.com>,
Linux Netdev List <netdev@...r.kernel.org>,
"oss-drivers@...ronome.com" <oss-drivers@...ronome.com>,
"Pieter Jansen van Vuuren" <pieter.jansenvanvuuren@...ronome.com>
Subject: RE: [PATCH net-next v2 9/9] nfp: add control message passing
capabilities to flower offloads
From: Or Gerlitz
> Sent: 29 June 2017 14:47
...
> > + nfp_flow->meta.key_len /= NFP_FL_LW_SIZ;
> > + nfp_flow->meta.mask_len /= NFP_FL_LW_SIZ;
> > + nfp_flow->meta.act_len /= NFP_FL_LW_SIZ;
>
> better to use use x >>= 2 instead x /= 4
>
> I saw it in other places across the patch/set
Provided the values are unsigned it makes no difference.
Having 2 matching constants just makes the code harder to read.
David
Powered by blists - more mailing lists