netdev - Re: [PATCH net-next] sctp: remove an unnecessary check from sctp_endpoint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170630165126.GN18138@localhost.localdomain>
Date:   Fri, 30 Jun 2017 13:51:26 -0300
From:   Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
To:     Xin Long <lucien.xin@...il.com>
Cc:     network dev <netdev@...r.kernel.org>, linux-sctp@...r.kernel.org,
        Neil Horman <nhorman@...driver.com>, davem@...emloft.net
Subject: Re: [PATCH net-next] sctp: remove an unnecessary check from
 sctp_endpoint_destroy

On Thu, Jun 29, 2017 at 05:28:06PM +0800, Xin Long wrote:
> ep->base.sk gets it's value since sctp_endpoint_new, nowhere
> will change it. So there's no need to check if it's null, as
> it can never be null.
> 
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>

> ---
>  net/sctp/endpointola.c | 14 ++++++--------
>  1 file changed, 6 insertions(+), 8 deletions(-)
> 
> diff --git a/net/sctp/endpointola.c b/net/sctp/endpointola.c
> index 3dcd0ec..7772ca4 100644
> --- a/net/sctp/endpointola.c
> +++ b/net/sctp/endpointola.c
> @@ -268,16 +268,14 @@ static void sctp_endpoint_destroy(struct sctp_endpoint *ep)
>  
>  	memset(ep->secret_key, 0, sizeof(ep->secret_key));
>  
> -	/* Give up our hold on the sock. */
>  	sk = ep->base.sk;
> -	if (sk != NULL) {
> -		/* Remove and free the port */
> -		if (sctp_sk(sk)->bind_hash)
> -			sctp_put_port(sk);
> +	/* Remove and free the port */
> +	if (sctp_sk(sk)->bind_hash)
> +		sctp_put_port(sk);
>  
> -		sctp_sk(sk)->ep = NULL;
> -		sock_put(sk);
> -	}
> +	sctp_sk(sk)->ep = NULL;
> +	/* Give up our hold on the sock */
> +	sock_put(sk);
>  
>  	kfree(ep);
>  	SCTP_DBG_OBJCNT_DEC(ep);
> -- 
> 2.1.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>