netdev - Re: [PATCH] net: axienet: add of_phy_connect call for XAE_PHY_TYPE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <425aed84-a1b6-b8da-5989-3bef5a03ead4@gmail.com>
Date:   Fri, 30 Jun 2017 10:30:38 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Alvaro Gamez Machado <alvaro.gamez@...ent.com>,
        Anirudha Sarangi <anirudh@...inx.com>,
        John Linn <John.Linn@...inx.com>,
        Michal Simek <michal.simek@...inx.com>,
        Sören Brinkmann <soren.brinkmann@...inx.com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: axienet: add of_phy_connect call for
 XAE_PHY_TYPE_MII case

On 06/30/2017 02:25 AM, Alvaro Gamez Machado wrote:
> This IP core has support for mii connectivity to the phy, so be ready to
> connect to it when this is the case.
> 
> Signed-off-by: Alvaro Gamez Machado <alvaro.gamez@...ent.com>
> ---
>  drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> index 33c595f4691d..9b3f55449b5e 100644
> --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> @@ -935,7 +935,11 @@ static int axienet_open(struct net_device *ndev)
>  		return ret;
>  
>  	if (lp->phy_node) {
> -		if (lp->phy_type == XAE_PHY_TYPE_GMII) {
> +		if (lp->phy_type == XAE_PHY_TYPE_MII) {
> +			phydev = of_phy_connect(lp->ndev, lp->phy_node,
> +						axienet_adjust_link, 0,
> +						PHY_INTERFACE_MODE_MII);
> +		} else if (lp->phy_type == XAE_PHY_TYPE_GMII) {
>  			phydev = of_phy_connect(lp->ndev, lp->phy_node,
>  						axienet_adjust_link, 0,
>  						PHY_INTERFACE_MODE_GMII);

Seems like this could be simplified even further if the values of
lp->phy_type directly mapped to those of phy_interface_t.
-- 
Florian