netdev - Re: [PATCH net-next] net/packet: Fix Tx queue selection for AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170703.021858.1360397700923467821.davem@davemloft.net>
Date:   Mon, 03 Jul 2017 02:18:58 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ivan.briano@...el.com
Cc:     netdev@...r.kernel.org, jesus.sanchez-palencia@...el.com,
        vinicius.gomes@...el.com, andre.guedes@...el.com
Subject: Re: [PATCH net-next] net/packet: Fix Tx queue selection for
 AF_PACKET

From: Iván Briano <ivan.briano@...el.com>
Date: Fri, 30 Jun 2017 14:02:32 -0700

> When PACKET_QDISC_BYPASS is not used, Tx queue selection will be done
> before the packet is enqueued, taking into account any mappings set by
> a queuing discipline such as mqprio without hardware offloading. This
> selection may be affected by a previously saved queue_mapping, either on
> the Rx path, or done before the packet reaches the device, as it's
> currently the case for AF_PACKET.
> 
> In order for queue selection to work as expected when using traffic
> control, there can't be another selection done before that point is
> reached, so move the call to packet_pick_tx_queue to
> packet_direct_xmit, leaving the default xmit path as it was before
> PACKET_QDISC_BYPASS was introduced.
> 
> A forward declaration of packet_pick_tx_queue() is introduced to avoid
> the need to reorder the functions within the file.
> 
> Signed-off-by: Iván Briano <ivan.briano@...el.com>

Please resubmit tihs with a proper "Fixes: " tag which shows what
commit introduced this problem.

Thanks.