netdev - Re: [PATCH net-next] net/mlxfw: Properly handle dependancy with non-loadable mlx5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170703.023238.1801330975202162070.davem@davemloft.net>
Date:   Mon, 03 Jul 2017 02:32:38 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ogerlitz@...lanox.com
Cc:     netdev@...r.kernel.org, saeedm@...lanox.com, mlxsw@...lanox.com
Subject: Re: [PATCH net-next] net/mlxfw: Properly handle dependancy with
 non-loadable mlx5

From: Or Gerlitz <ogerlitz@...lanox.com>
Date: Sun,  2 Jul 2017 18:57:28 +0300

> If mlx5 is set to be built-in and mlxfw as a module, we
> get a link error:
> 
> drivers/built-in.o: In function `mlx5_firmware_flash':
> (.text+0x5aed72): undefined reference to `mlxfw_firmware_flash'
> 
> Since we don't want to mandate selecting mlxfw for mlx5 users, we
> use the IS_REACHABLE macro to make sure that a stub is exposed
> to the caller.
> 
> Signed-off-by: Or Gerlitz <ogerlitz@...lanox.com>
> Reported-by: Jakub Kicinski <kubakici@...pl>
> Reported-by: Arnd Bergmann <arnd@...db.de>

Applied, thank you.