netdev - Re: [PATCH 1/1] mlx4_en: make mlx4_log_num_mgm_entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 3 Jul 2017 09:09:56 +0300
From:   Yuval Shaia <yuval.shaia@...cle.com>
To:     Zhu Yanjun <yanjun.zhu@...cle.com>
Cc:     tariqt@...lanox.com, netdev@...r.kernel.org,
        linux-rdma@...r.kernel.org, leon@...nel.org
Subject: Re: [PATCH 1/1] mlx4_en: make mlx4_log_num_mgm_entry_size static

On Mon, Jul 03, 2017 at 01:35:19AM -0400, Zhu Yanjun wrote:
> The variable mlx4_log_num_mgm_entry_size is only called in main.c.
> 
> CC: Joe Jin <joe.jin@...cle.com>
> CC: Junxiao Bi <junxiao.bi@...cle.com>
> Signed-off-by: Zhu Yanjun <yanjun.zhu@...cle.com>
> ---
>  drivers/net/ethernet/mellanox/mlx4/main.c | 2 +-
>  drivers/net/ethernet/mellanox/mlx4/mlx4.h | 1 -
>  2 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c
> index 83aab1e..4b67277 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/main.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/main.c
> @@ -91,7 +91,7 @@ module_param_array(probe_vf, byte, &probe_vfs_argc, 0444);
>  MODULE_PARM_DESC(probe_vf, "number of vfs to probe by pf driver (num_vfs > 0)\n"
>  			   "probe_vf=port1,port2,port1+2");
>  
> -int mlx4_log_num_mgm_entry_size = MLX4_DEFAULT_MGM_LOG_ENTRY_SIZE;
> +static int mlx4_log_num_mgm_entry_size = MLX4_DEFAULT_MGM_LOG_ENTRY_SIZE;
>  module_param_named(log_num_mgm_entry_size,
>  			mlx4_log_num_mgm_entry_size, int, 0444);
>  MODULE_PARM_DESC(log_num_mgm_entry_size, "log mgm size, that defines the num"
> diff --git a/drivers/net/ethernet/mellanox/mlx4/mlx4.h b/drivers/net/ethernet/mellanox/mlx4/mlx4.h
> index b4f1bc5..a3f5edb 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/mlx4.h
> +++ b/drivers/net/ethernet/mellanox/mlx4/mlx4.h
> @@ -231,7 +231,6 @@ do {									\
>  #define mlx4_warn(mdev, format, ...)					\
>  	dev_warn(&(mdev)->persist->pdev->dev, format, ##__VA_ARGS__)
>  
> -extern int mlx4_log_num_mgm_entry_size;

Reviewed-by: Yuval Shaia <yuval.shaia@...cle.com>

>  extern int log_mtts_per_seg;
>  extern int mlx4_internal_err_reset;
>  
> -- 
> 2.7.4
>