netdev - Re: [PATCH RFC 1/2] skbuff: Function to send an skbuf on a socket

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170703.060057.586366984268237880.davem@davemloft.net>
Date:   Mon, 03 Jul 2017 06:00:57 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     tom@...bertland.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH RFC 1/2] skbuff: Function to send an skbuf on a socket

From: Tom Herbert <tom@...bertland.com>
Date: Thu, 29 Jun 2017 11:27:04 -0700

> +int skb_send_sock(struct sk_buff *skb, struct socket *sock, unsigned int offset)
> +{
> +	unsigned int sent = 0;
> +	unsigned int ret;
> +	unsigned short fragidx;

Please use reverse christmas tree ordering for these local variables.

> +	/* Deal with head data */
> +	while (offset < skb_headlen(skb)) {
> +		size_t len = skb_headlen(skb) - offset;
> +		struct kvec kv;
> +		struct msghdr msg;

Likewise.