netdev - Re: [PATCH net 1/2] vxlan: fix hlist corruption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bdd5d0e8-b8fa-2c81-07ad-17ad89b6c052@redhat.com>
Date:   Mon, 3 Jul 2017 09:25:45 -0400
From:   Waiman Long <longman@...hat.com>
To:     Jiri Benc <jbenc@...hat.com>
Cc:     netdev@...r.kernel.org,
        "John W. Linville" <linville@...driver.com>,
        pravin shelar <pshelar@....org>
Subject: Re: [PATCH net 1/2] vxlan: fix hlist corruption

On 07/03/2017 04:23 AM, Jiri Benc wrote:
> On Sun, 2 Jul 2017 16:06:10 -0400, Waiman Long wrote:
>> I didn't see any init code for hlist4 and hlist6. Is vxlan_dev going to
>> be *zalloc'ed so that they are guaranteed to be NULL? If not, you may
>> need to add  init code as not both hlists will be hashed and so one of
>> them may contain invalid data.
> Yes, it's zalloced via alloc_netdev. No need to init the fields
> explicitly.
>
>  Jiri

Thanks for the clarification.

-Longman