netdev - Re: [PATCH][bpf-next] bpf: add missing break in for the TCP_BPF_SNDCWND

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <385C64DB-4BF4-4AC1-B7F0-76AB30969682@fb.com>
Date:   Tue, 4 Jul 2017 18:26:34 +0000
From:   Lawrence Brakmo <brakmo@...com>
To:     Daniel Borkmann <daniel@...earbox.net>,
        Colin King <colin.king@...onical.com>,
        Alexei Starovoitov <ast@...nel.org>,
        "David S . Miller" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][bpf-next] bpf: add missing break in for the
 TCP_BPF_SNDCWND_CLAMP case



On 7/4/17, 8:26 AM, "netdev-owner@...r.kernel.org on behalf of Daniel Borkmann" <netdev-owner@...r.kernel.org on behalf of daniel@...earbox.net> wrote:

    [ +Lawrence ]
    
    On 07/04/2017 05:21 PM, Colin King wrote:
    > From: Colin Ian King <colin.king@...onical.com>
    >
    > There appears to be a missing break in the TCP_BPF_SNDCWND_CLAMP case.
    > Currently the non-error path where val is greater than zero falls through
    > to the default case that sets the error return to -EINVAL. Add in
    > the missing break.
    >
    > Detected by CoverityScan, CID#1449376 ("Missing break in switch")
    >
    > Fixes: 13bf96411ad2 ("bpf: Adds support for setting sndcwnd clamp")
    > Signed-off-by: Colin Ian King <colin.king@...onical.com>
    
    Acked-by: Daniel Borkmann daniel@...earbox.net
Acked-by: Lawrence Brakmo <brakmo@...com>
    
    > ---
    >   net/core/filter.c | 1 +
    >   1 file changed, 1 insertion(+)
    >
    > diff --git a/net/core/filter.c b/net/core/filter.c
    > index 94169572d002..c7f737058d89 100644
    > --- a/net/core/filter.c
    > +++ b/net/core/filter.c
    > @@ -2867,6 +2867,7 @@ BPF_CALL_5(bpf_setsockopt, struct bpf_sock_ops_kern *, bpf_sock,
    >   					tp->snd_cwnd_clamp = val;
    >   					tp->snd_ssthresh = val;
    >   				}
    > +				break;
    >   			default:
    >   				ret = -EINVAL;
    >   			}
    >