netdev - Re: [PATCH net-next] bpf: fix return in load_bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <F15368B9-F79E-4296-958E-9DCF3CFDA7BF@fb.com>
Date:   Tue, 4 Jul 2017 22:55:59 +0000
From:   Lawrence Brakmo <brakmo@...com>
To:     Daniel Borkmann <daniel@...earbox.net>,
        netdev <netdev@...r.kernel.org>
CC:     Kernel Team <Kernel-team@...com>, Alexei Starovoitov <ast@...com>
Subject: Re: [PATCH net-next] bpf: fix return in load_bpf_file


On 7/4/17, 3:14 PM, "Daniel Borkmann" <daniel@...earbox.net> wrote:

    On 07/04/2017 11:51 PM, Lawrence Brakmo wrote:
    > The function load_bpf_file ignores the return value of
    > load_and_attach(), so even if load_and_attach() returns an error,
    > load_bpf_file() will return 0.
    >
    > Now, load_bpf_file() can call load_and_attach() multiple times and some
    > can succeed and some could fail. I think the correct behavor is to
    > return error on the first failed load_and_attach().
    
    Your SOB is missing.

Oops, thanks. New patch forthcoming.