netdev - Re: [PATCH RFC 11/12] net: Remove all references to SKB_GSO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF=yD-+nZMDnAgHkT=hDONA1mtB3r4F2nct0aVuUtA8tXp9RLw@mail.gmail.com>
Date:   Wed, 5 Jul 2017 13:21:02 -0400
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     Network Development <netdev@...r.kernel.org>
Subject: Re: [PATCH RFC 11/12] net: Remove all references to SKB_GSO_UDP.

On Wed, Jul 5, 2017 at 12:06 PM, Willem de Bruijn
<willemdebruijn.kernel@...il.com> wrote:
>> diff --git a/include/linux/virtio_net.h b/include/linux/virtio_net.h
>> index 5209b5e..32fb046 100644
>> --- a/include/linux/virtio_net.h
>> +++ b/include/linux/virtio_net.h
>> @@ -18,9 +18,6 @@ static inline int virtio_net_hdr_to_skb(struct sk_buff *skb,
>>                 case VIRTIO_NET_HDR_GSO_TCPV6:
>>                         gso_type = SKB_GSO_TCPV6;
>>                         break;
>> -               case VIRTIO_NET_HDR_GSO_UDP:
>> -                       gso_type = SKB_GSO_UDP;
>> -                       break;
>
> Virtio devices negotiate feature support before using this, but
> tuntap and pf_packet may be passing these packets unconditionally.
> Perhaps we should fragment those on the spot with skb_segment.

Tun has ioctl TUNSETIFF to probe for features and it can be argued
that packet sockets should query device features with ethtool before
relying on them. So perhaps we don't need to fix this up, after all.