netdev - Re: [PATCH net] net: ipv6: Compare lwstate in detecting duplicate nexthops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170705213846.GP22185@wantstofly.org>
Date:   Thu, 6 Jul 2017 00:38:46 +0300
From:   Lennert Buytenhek <buytenh@...tstofly.org>
To:     David Ahern <dsahern@...il.com>,
        Roopa Prabhu <roopa@...ulusnetworks.com>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Robert Shearman <rshearma@...cade.com>
Subject: Re: [PATCH net] net: ipv6: Compare lwstate in detecting duplicate
 nexthops

On Wed, Jul 05, 2017 at 02:14:33PM -0700, Roopa Prabhu wrote:

> > Lennert reported a failure to add different mpls encaps in a multipath
> > route:
> >
> >   $ ip -6 route add 1234::/16 \
> >         nexthop encap mpls 10 via fe80::1 dev ens3 \
> >         nexthop encap mpls 20 via fe80::1 dev ens3
> >   RTNETLINK answers: File exists
> >
> > The problem is that the duplicate nexthop detection does not compare
> > lwtunnel configuration. Add it.
> >
> > Fixes: 19e42e451506("ipv6: support for fib route lwtunnel encap attributes")
> > Signed-off-by: David Ahern <dsahern@...il.com>
> 
> Reported-by: João Taveira Araújo <joao.taveira@...il.com>
> 
> Reported-by: Lennert Buytenhek <buytenh@...tstofly.org>
> 
> Acked-by: Roopa Prabhu <roopa@...ulusnetworks.com>

Tested-by: Lennert Buytenhek <buytenh@...tstofly.org>

Seems to work!  Thanks!