netdev - [RFC] tls: length check correct in do_tls_getsockopt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <a0dac911-6401-12cb-611c-5a1723d943c1@gmail.com>
Date:   Wed, 5 Jul 2017 03:10:53 -0400
From:   Matthias Rosenfelder <mrosenfelder.lkml@...il.com>
To:     netdev@...r.kernel.org
Cc:     davem@...emloft.net, dan.carpenter@...cle.com, davejwatson@...com
Subject: [RFC] tls: length check correct in do_tls_getsockopt_tx()?

Hi,

In do_tls_getsockopt_tx():

if (len == sizeof(crypto_info)) {

should be

if (len == sizeof(*crypto_info)) {

as crypto_info is of pointer type. Or am I missing something?

btw: I am not very familiar with sockets. So I am wondering
what is the use of this functionality? Why copy only the header
to userspace?

Thanks.
Best Regards,

Matthias