netdev - Re: [PATCH iproute/master 0/3] lost mpls ip tunnel patches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170705090650.6598846d@xeon-e3>
Date:   Wed, 5 Jul 2017 09:06:50 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Krister Johansen <kjlx@...pleofstupid.com>
Cc:     netdev@...r.kernel.org, simon.horman@...ronome.com,
        dsahern@...il.com
Subject: Re: [PATCH iproute/master 0/3] lost mpls ip tunnel patches

On Fri,  9 Jun 2017 18:31:29 -0700
Krister Johansen <kjlx@...pleofstupid.com> wrote:

> Hi Stephen,
> I'm a bit unsure of the decorum in this particular situation. Kernel
> support for mpls/ip tunnels was integrated back in July of 2016.  At the
> time, the author of that feature sent out a RFC patch for the iproute
> support but never followed up on subsequent code review comments.
> 
> The kernel support got merged, but the iproute support never made it in.
> I wanted to run some tests with these features.  In the process, I
> tracked down the author's original patches, merged them into current
> iproute, and attempted to address the comments from code reviewers.
> 
> I've attached an 'Original-Author' label to each commit, and have CC'd
> him and the code reviewer on this patch.  If any part of this is
> improper, please let me know and I'll respin accordingly.  Mostly, I
> wanted to close the loop here so the mpls in ip tunnel support is usable
> through iproute.
> 
> The original threads for the 2016 patch are here:
> 
> http://marc.info/?l=linux-netdev&m=146782946216005&w=2
> http://marc.info/?l=linux-netdev&m=146782941615977&w=2
> http://marc.info/?l=linux-netdev&m=146782947016007&w=2
> http://marc.info/?l=linux-netdev&m=146782942915988&w=2
> 
> Thanks,
> 
> -K
> 
> Krister Johansen (3):
>   iptunnel: document mode parameter for sit tunnels
>   iptunnel: add support for mpls/ip to sit tunnels
>   iptunnel: add support for mpls/ip to ipip tunnels
> 
>  include/utils.h       |  3 +++
>  ip/link_iptnl.c       | 30 ++++++++++++++++++++++++++----
>  ip/tunnel.c           |  3 +++
>  man/man8/ip-link.8.in | 12 +++++++++++-
>  4 files changed, 43 insertions(+), 5 deletions(-)
> 

I went ahead and merged these in. Would be better to get the headers
stuff straightened out but that is probably an endless battle.