netdev - Re: [PATCHv2 1/3] ethtool: stmmac: Fix Designware ethtool register dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <81e6d065-bd74-6af8-de4f-7722d0b1e270@linux.intel.com>
Date:   Thu, 6 Jul 2017 15:22:59 -0500
From:   Thor Thayer <thor.thayer@...ux.intel.com>
To:     linville@...driver.com, peppe.cavallaro@...com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCHv2 1/3] ethtool: stmmac: Fix Designware ethtool register
 dump

On 06/28/2017 10:13 AM, thor.thayer@...ux.intel.com wrote:
> From: Thor Thayer <thor.thayer@...ux.intel.com>
> 
> The commit fbf68229ffe7 ("net: stmmac: unify registers dumps methods")
> 
> in the Linux kernel modified the register dump to store the DMA registers
> at the DMA register offset (0x1000) but ethtool (stmmac.c) looks for the
> DMA registers after the MAC registers which is offset 12.
> This patch adds the DMA register offset so that indexing is correct.
> 
> Signed-off-by: Thor Thayer <thor.thayer@...ux.intel.com>
> Acked-by: Giuseppe Cavallaro <peppe.cavallaro@...com>
> ---
> v2  Modify the commit message to specify commit from Linux kernel.
>      Add Acked-by.
> ---

Please disregard this patch.

After further reflection, it would be better to leave this alone and 
change the kernel driver. This change would require using different 
ethtool for different versions.

The other 2 patches with macro changes are still valid.

Thanks,

Thor

>   stmmac.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/stmmac.c b/stmmac.c
> index fb69bfe..e1bb291 100644
> --- a/stmmac.c
> +++ b/stmmac.c
> @@ -14,6 +14,9 @@
>   #include <string.h>
>   #include "internal.h"
>   
> +/* The DMA Registers start at offset 0x1000 in the DW IP */
> +#define DMA_REG_OFFSET	(0x1000 / 4)
> +
>   int st_mac100_dump_regs(struct ethtool_drvinfo *info,
>   			struct ethtool_regs *regs)
>   {
> @@ -36,6 +39,7 @@ int st_mac100_dump_regs(struct ethtool_drvinfo *info,
>   
>   	fprintf(stdout, "\n");
>   	fprintf(stdout, "DMA Registers\n");
> +	stmmac_reg = (unsigned int *)regs->data + DMA_REG_OFFSET;
>   	for (i = 0; i < 9; i++)
>   		fprintf(stdout, "CSR%d  0x%08X\n", i, *stmmac_reg++);
>   
> @@ -59,6 +63,7 @@ int st_gmac_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs *regs)
>   
>   	fprintf(stdout, "\n");
>   	fprintf(stdout, "DMA Registers\n");
> +	stmmac_reg = (unsigned int *)regs->data + DMA_REG_OFFSET;
>   	for (i = 0; i < 22; i++)
>   		fprintf(stdout, "Reg%d  0x%08X\n", i, *stmmac_reg++);
>   
>