netdev - RE: [PATCH v2 2/2] ARM: shmobile: defconfig: Enable Ethernet AVB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <TY1PR06MB07020F58F15C964FC1AA1D22B7D50@TY1PR06MB0702.apcprd06.prod.outlook.com>
Date:   Thu, 6 Jul 2017 08:05:43 +0000
From:   Chris Paterson <Chris.Paterson2@...esas.com>
To:     Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
        Biju Das <biju.das@...renesas.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Russell King <linux@...linux.org.uk>
CC:     Simon Horman <horms@...ge.net.au>,
        Magnus Damm <magnus.damm@...il.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH v2 2/2] ARM: shmobile: defconfig: Enable Ethernet AVB

Hello Sergei, 

Thank you for your comments.

> From: Sergei Shtylyov [mailto:sergei.shtylyov@...entembedded.com]
> Sent: 05 July 2017 17:14
> 
> Hello!
> 
> On 07/05/2017 06:56 PM, Biju Das wrote:
> 
> > The iWave RZ/G1M Q7 SOM supports Gigabit Ethernet Phy (Micrel
> KSZ9031MNX).
> > Gigabit Ethernet support is available in Renesas AVB driver.
> > To increase hardware support enable the driver in the
> > shmobile_defconfig multiplatform configuration.
> >
> > Signed-off-by: Biju Das <biju.das@...renesas.com>
> > Reviewed-by: Chris Paterson <chris.paterson2@...esas.com>
> > Acked-by: Geert Uytterhoeven <geert+renesas@...der.be>
> > ---
> >  arch/arm/configs/shmobile_defconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/configs/shmobile_defconfig
> > b/arch/arm/configs/shmobile_defconfig
> > index 3c66a42..d992911 100644
> > --- a/arch/arm/configs/shmobile_defconfig
> > +++ b/arch/arm/configs/shmobile_defconfig
> > @@ -83,6 +83,7 @@ CONFIG_NETDEVICES=y
> >  # CONFIG_NET_VENDOR_MICREL is not set  #
> CONFIG_NET_VENDOR_NATSEMI is
> > not set  CONFIG_SH_ETH=y
> > +CONFIG_RAVB=y
> 
>     Hm, I would enable it only as a module, given it's not easy to make use of
> AVB on the 32-bit boards.

On the iWave-M platforms the only available Ethernet interface is AVB. Without including the RAVB driver in the Kernel we won't be able to use NFS.

I know adding CONFIG_RAVB for all shmobile devices may increase the Kernel size for everyone, especially when most cannot use AVB without an add-on board, but I don't think the increase will be big.


Kind regards, Chris 

> 
> [...]
> 
> MBR Sergei