netdev - Re: [PATCH] mwifiex: fix compile warning of unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5adbeb32-7510-d08e-9bb6-c18fd490388c@rock-chips.com>
Date:   Thu, 6 Jul 2017 16:18:56 +0800
From:   Shawn Lin <shawn.lin@...k-chips.com>
To:     Kalle Valo <kvalo@...eaurora.org>
Cc:     shawn.lin@...k-chips.com, Amitkumar Karwar <amitkarwar@...il.com>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        Nishant Sarmukadam <nishants@...vell.com>,
        Xinming Hu <huxm@...vell.com>
Subject: Re: [PATCH] mwifiex: fix compile warning of unused variable

Hi Kalle,

On 2017/7/6 15:57, Kalle Valo wrote:
> Shawn Lin <shawn.lin@...k-chips.com> writes:
> 
>> We got a compile warning shows below:
>>
>> drivers/net/wireless/marvell/mwifiex/sdio.c: In function
>> 'mwifiex_sdio_remove':
>> drivers/net/wireless/marvell/mwifiex/sdio.c:377:6: warning: variable
>> 'ret' set but not used [-Wunused-but-set-variable]
>>
>> Per the code, it didn't check if mwifiex_sdio_read_fw_status
>> finish successfully. We should at least check the return of
>> mwifiex_sdio_read_fw_status, otherwise the following check of
>> firmware_stat and adapter->mfg_mode is pointless as the device
>> is probably dead.
> 
> I don't see that warning, any ideas why? My compiler:
> 
> gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609

I was using gcc-arm-eabi-4.8- , but it doesn't matter.

Could you add W=1 to compile the code, for instance, "make W=1  -j32"

> 
>