netdev - RE: [PATCH 1/1] net sched: Added the TC_LINKLAYER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <063D6719AE5E284EB5DD2968C1650D6DD0033CC1@AcuExch.aculab.com>
Date:   Thu, 6 Jul 2017 09:03:09 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     "'McCabe, Robert J'" <Robert.McCabe@...kwellcollins.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     "McCabe@...kwellcollins.com" <McCabe@...kwellcollins.com>
Subject: RE: [PATCH 1/1] net sched: Added the TC_LINKLAYER_CUSTOM linklayer
 type

From: McCabe, Robert J
> Sent: 04 July 2017 01:14
> +	if (nla_put(skb, TCA_STAB_DATA, sizeof(stab->szopts)*sizeof(u16), &stab->data))
> +		goto nla_put_failure;

Multiplying sizeof(a) by sizeof(b) really doesn't look right at all.

	David