netdev - Re: [PATCH net-next] TLS: Fix length check in do_tls_getsockopt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170706.105848.1241930716639339836.davem@davemloft.net>
Date:   Thu, 06 Jul 2017 10:58:48 +0100 (WEST)
From:   David Miller <davem@...emloft.net>
To:     mrosenfelder.lkml@...il.com
Cc:     netdev@...r.kernel.org, dan.carpenter@...cle.com,
        davejwatson@...com, aviadye@...lanox.com, ilyal@...lanox.com
Subject: Re: [PATCH net-next] TLS: Fix length check in
 do_tls_getsockopt_tx()

From: Matthias Rosenfelder <mrosenfelder.lkml@...il.com>
Date: Thu, 6 Jul 2017 00:56:36 -0400

> copy_to_user() copies the struct the pointer is pointing to, but the
> length check compares against sizeof(pointer) and not sizeof(struct).
> On 32-bit the size is probably the same, so it might have worked
> accidentally.
> 
> Signed-off-by: Matthias Rosenfelder <mrosenfelder.lkml@...il.com>

Applied, thanks.