netdev - Re: [PATCH v3 net-next 0/4] kernel TLS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170706144854.GA96869@davejwatson-mba.dhcp.thefacebook.com>
Date:   Thu, 6 Jul 2017 07:48:54 -0700
From:   Dave Watson <davejwatson@...com>
To:     Richard Weinberger <richard.weinberger@...il.com>
CC:     Ilya Lesokhin <ilyal@...lanox.com>,
        Aviad Yehezkel <aviadye@...lanox.com>,
        Boris Pismenny <borisp@...lanox.com>,
        Liran Liss <liranl@...lanox.com>,
        Matan Barak <matanb@...lanox.com>,
        David Miller <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Tom Herbert <tom@...bertland.com>,
        "herbert@...dor.apana.org.au" <herbert@...dor.apana.org.au>,
        <linux-crypto@...r.kernel.org>,
        Hannes Frederic Sowa <hannes@...essinduktion.org>,
        Eric Dumazet <eric.dumazet@...il.com>,
        Alexei Starovoitov <alexei.starovoitov@...il.com>,
        <nmav@...tls.org>, <fridolin.pokorny@...il.com>
Subject: Re: [PATCH v3 net-next 0/4] kernel TLS

Hi Richard, 

On 07/06/17 04:30 PM, Richard Weinberger wrote:
> Dave,
> 
> On Wed, Jun 14, 2017 at 8:36 PM, Dave Watson <davejwatson@...com> wrote:
> >  Documentation/networking/tls.txt   | 135 +++++++
> >  MAINTAINERS                        |  10 +
> >  include/linux/socket.h             |   1 +
> >  include/net/inet_connection_sock.h |   4 +
> >  include/net/tcp.h                  |  27 ++
> >  include/net/tls.h                  | 237 ++++++++++++
> >  include/uapi/linux/tcp.h           |   1 +
> >  include/uapi/linux/tls.h           |  79 ++++
> >  net/Kconfig                        |   1 +
> >  net/Makefile                       |   1 +
> >  net/ipv4/Makefile                  |   2 +-
> >  net/ipv4/sysctl_net_ipv4.c         |  25 ++
> >  net/ipv4/tcp.c                     |  33 +-
> >  net/ipv4/tcp_ipv4.c                |   2 +
> >  net/ipv4/tcp_rate.c                |   1 +
> >  net/ipv4/tcp_ulp.c                 | 134 +++++++
> >  net/tls/Kconfig                    |  12 +
> >  net/tls/Makefile                   |   7 +
> >  net/tls/tls_main.c                 | 487 +++++++++++++++++++++++
> >  net/tls/tls_sw.c                   | 772 +++++++++++++++++++++++++++++++++++++
> >  20 files changed, 1968 insertions(+), 3 deletions(-)
> >  create mode 100644 Documentation/networking/tls.txt
> >  create mode 100644 include/net/tls.h
> >  create mode 100644 include/uapi/linux/tls.h
> >  create mode 100644 net/ipv4/tcp_ulp.c
> >  create mode 100644 net/tls/Kconfig
> >  create mode 100644 net/tls/Makefile
> >  create mode 100644 net/tls/tls_main.c
> >  create mode 100644 net/tls/tls_sw.c
> 
> Sorry for the late question. Do I miss something or is this IPv4 only?

The hooks it currently overrides / uses from proto_ops (sendmsg, sendpage,
get/setsockopt, close) are the same for ipv4 & ipv6, so it should work
for both.  Our test suites have been passing in both, at least.