netdev - Re: [PATCH net] vrf: fix bug_on triggered by rx when destroying a vrf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 6 Jul 2017 09:32:24 -0600
From:   David Ahern <dsahern@...il.com>
To:     Nikolay Aleksandrov <nikolay@...ulusnetworks.com>,
        netdev@...r.kernel.org
Cc:     chriscormier@...ulusnetworks.com, davem@...emloft.net
Subject: Re: [PATCH net] vrf: fix bug_on triggered by rx when destroying a vrf

On 7/6/17 6:24 AM, Nikolay Aleksandrov wrote:
> When destroying a VRF device we cleanup the slaves in its ndo_uninit()
> function, but that causes packets to be switched (skb->dev == vrf being
> destroyed) even though we're pass the point where the VRF should be
> receiving any packets while it is being dismantled. This causes a BUG_ON
> to trigger if we have raw sockets (trace below).
> The reason is that the inetdev of the VRF has been destroyed but we're
> still sending packets up the stack with it, so let's free the slaves in
> the dellink callback as David Ahern suggested.
...

> Fixes: 193125dbd8eb ("net: Introduce VRF device driver")
> Reported-by: Chris Cormier <chriscormier@...ulusnetworks.com>
> Signed-off-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
> ---
>  drivers/net/vrf.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 

Thanks for the fix.

Acked-by: David Ahern <dsahern@...il.com>