netdev - Re: [PATCH] net: ethernet: mediatek: remove useless code in mtk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 08 Jul 2017 11:28:19 +0100 (WEST)
From:   David Miller <davem@...emloft.net>
To:     garsilva@...eddedor.com
Cc:     andrew@...n.ch, nbd@...nwrt.org, blogic@...nwrt.org,
        matthias.bgg@...il.com, netdev@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: ethernet: mediatek: remove useless code in
 mtk_probe()

From: "Gustavo A. R. Silva" <garsilva@...eddedor.com>
Date: Fri, 7 Jul 2017 15:23:34 -0500

> Remove useless local variables _match_, _soc_ and the code related.
> 
> Notice that
> 
> const struct of_device_id of_mtk_match[] = {
>         { .compatible = "mediatek,mt2701-eth" },
>         {},
> };
> 
> So match->data is NULL.
> 
> Suggested-by: Andrew Lunn <andrew@...n.ch>
> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>

Applied, thanks.

If someone needs this they can it back, in a less buggy form.