netdev - Re: [PATCH] net/mlx5: IPSec, fix 64-bit division correctly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170710.193439.1383814646174599742.davem@davemloft.net>
Date:   Mon, 10 Jul 2017 19:34:39 +0100 (WEST)
From:   David Miller <davem@...emloft.net>
To:     arnd@...db.de
Cc:     saeedm@...lanox.com, ilant@...lanox.com, matanb@...lanox.com,
        leonro@...lanox.com, yossiku@...lanox.com, kliteyn@...lanox.com,
        borisp@...lanox.com, netdev@...r.kernel.org,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/mlx5: IPSec, fix 64-bit division correctly

From: Arnd Bergmann <arnd@...db.de>
Date: Mon, 10 Jul 2017 11:37:51 +0200

> The new IPSec offload code introduced a build error:
> 
> drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_rxtx.o: In function `mlx5e_ipsec_build_inverse_table':
> ipsec_rxtx.c:(.text+0x556): undefined reference
> 
> Another patch was added on top to fix the build error, but
> that introduced a new bug, as we now use the remainder of
> the division rather than the result.
> 
> This makes it use the correct helper function instead.
> 
> Fixes: 5dfd87b67cd9 ("net/mlx5: IPSec, Fix 64-bit division on 32-bit builds")
> Fixes: 2ac9cfe78223 ("net/mlx5e: IPSec, Add Innova IPSec offload TX data path")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied, thanks.