netdev - Re: [PATCH net v2] samples/bpf: fix a build issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D09C7CAC-32AB-43D6-8518-7470C749AE4F@fb.com>
Date:   Mon, 10 Jul 2017 22:10:14 +0000
From:   Lawrence Brakmo <brakmo@...com>
To:     Daniel Borkmann <daniel@...earbox.net>, Yonghong Song <yhs@...com>,
        Alexei Starovoitov <ast@...com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     Kernel Team <Kernel-team@...com>
Subject: Re: [PATCH net v2] samples/bpf: fix a build issue



On 7/10/17, 2:13 PM, "Daniel Borkmann" <daniel@...earbox.net> wrote:

    On 07/10/2017 11:04 PM, Yonghong Song wrote:
    > With latest net-next:
    > ====
    > clang  -nostdinc -isystem /usr/lib/gcc/x86_64-redhat-linux/6.3.1/include -I./arch/x86/include -I./arch/x86/include/generated/uapi -I./arch/x86/include/generated  -I./include -I./arch/x86/include/uapi -I./include/uapi -I./include/generated/uapi -include ./include/linux/kconfig.h  -Isamples/bpf \
    >      -D__KERNEL__ -D__ASM_SYSREG_H -Wno-unused-value -Wno-pointer-sign \
    >      -Wno-compare-distinct-pointer-types \
    >      -Wno-gnu-variable-sized-type-not-at-end \
    >      -Wno-address-of-packed-member -Wno-tautological-compare \
    >      -Wno-unknown-warning-option \
    >      -O2 -emit-llvm -c samples/bpf/tcp_synrto_kern.c -o -| llc -march=bpf -filetype=obj -o samples/bpf/tcp_synrto_kern.o
    > samples/bpf/tcp_synrto_kern.c:20:10: fatal error: 'bpf_endian.h' file not found
    >            ^~~~~~~~~~~~~~
    > 1 error generated.
    > ====
    >
    > net has the same issue.
    >
    > Add support for ntohl and htonl in tools/testing/selftests/bpf/bpf_endian.h.
    > Also move bpf_helpers.h from samples/bpf to selftests/bpf and change
    > compiler include logic so that programs in samples/bpf can access the headers
    > in selftests/bpf, but not the other way around.
    >
    > Signed-off-by: Yonghong Song <yhs@...com>
    
    LGTM, thanks!
    
    Acked-by: Daniel Borkmann daniel@...earbox.net

Acked-by: Lawrence Brakmo <brakmo@...com>