netdev - Re: [PATCH 1/2 net] ptp: fix error codes in ptp_clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170710110246.inwp2frouj7gvqzf@localhost.localdomain>
Date:   Mon, 10 Jul 2017 13:02:46 +0200
From:   Richard Cochran <richardcochran@...il.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Ganesh Goudar <ganeshgr@...lsio.com>,
        Atul Gupta <atul.gupta@...lsio.com>, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 1/2 net] ptp: fix error codes in ptp_clock_register()

On Mon, Jul 10, 2017 at 01:29:20PM +0300, Dan Carpenter wrote:
> The "goto no_pps" was a bug you introduced.

I took a second look, and yes, the original commit should not have
returned NULL, and the original callers did not expect NULL either.
 
> But I feel like you're being rude, so I'm not going to resend these
> patches.  Please fix them yourself.

Sorry you feel that way.  Your first patch, although now more or less
cosmetic, would be okay.  The second patch is still wrong.

Thanks,
Richard