netdev - Re: [PATCH V3] Set NTB format again after altsetting switch for Huawei devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <87bmoqad6f.fsf@miraculix.mork.no>
Date:   Tue, 11 Jul 2017 23:14:48 +0200
From:   Bjørn Mork <bjorn@...k.no>
To:     Oliver Neukum <oliver@...kum.org>
Cc:     Enrico Mioso <mrkiko.rs@...il.com>,
        Christian Panton <christian@...ton.org>,
        linux-usb@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH V3] Set NTB format again after altsetting switch for Huawei devices

Oliver Neukum <oliver@...kum.org> writes:
> Am Dienstag, den 11.07.2017, 17:21 +0200 schrieb Enrico Mioso:
>> Some firmwares in Huawei E3372H devices have been observed to switch back
>> to NTB 32-bit format after altsetting switch.
>> This patch implements a driver flag to check for the device settings and
>> set NTB format to 16-bit again if needed.
>> The flag has been activated for devices controlled by the huawei_cdc_ncm.c
>> driver.
>
> Hi,
>
> does this cover reset_resume()?

AFAIK reset_resume doesn't really work for 3G/LTE modems.  Too much
state to restore both in firmware and network, with no well defined
protocol to restore it.

The only reason for having reset_resume in the modem drivers is that
quite a few modems have an SD reader. We need to support persist for the
usb-storage function, even if the modem functions fail.  There is no
reason to mess up the file system too.

Bjørn