netdev - Re: [PATCH v2] dt-bindings: net: ravb : Add support for r8a7743 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52eb0b92-5d25-e1f4-df54-e4fcf648c90e@cogentembedded.com>
Date:   Tue, 11 Jul 2017 15:12:14 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Biju Das <biju.das@...renesas.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Russell King <linux@...linux.org.uk>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Simon Horman <horms@...ge.net.au>,
        Magnus Damm <magnus.damm@...il.com>,
        Chris Paterson <chris.paterson2@...esas.com>,
        devicetree@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org
Subject: Re: [PATCH v2] dt-bindings: net: ravb : Add support for r8a7743 SoC

Hello!

On 07/10/2017 06:32 PM, Biju Das wrote:

> Add a new compatible string for the RZ/G1M (R8A7743) SoC.
>
> Signed-off-by: Biju Das <biju.das@...renesas.com>
> ---
> v1->v2
> * Changed the subject
> * re-formatted the required properties
>
>  .../devicetree/bindings/net/renesas,ravb.txt       | 29 +++++++++++++---------
>  1 file changed, 17 insertions(+), 12 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> index b519503..4717bc2 100644
> --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
> +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> @@ -4,19 +4,24 @@ This file provides information on what the device node for the Ethernet AVB
>  interface contains.
>
>  Required properties:
> -- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC.
> -	      "renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC.
> -	      "renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC.
> -	      "renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC.
> -	      "renesas,etheravb-r8a7794" if the device is a part of R8A7794 SoC.
> -	      "renesas,etheravb-r8a7795" if the device is a part of R8A7795 SoC.
> -	      "renesas,etheravb-r8a7796" if the device is a part of R8A7796 SoC.
> -	      "renesas,etheravb-rcar-gen2" for generic R-Car Gen 2 compatible interface.
> -	      "renesas,etheravb-rcar-gen3" for generic R-Car Gen 3 compatible interface.
> +- compatible: Must contain one or more of the following:

    No, it can't contain more than one SoC specific value.

> +      - "renesas,etheravb-r8a7743" for the R8A7743 SoC.
> +      - "renesas,etheravb-r8a7790" for the R8A7790 SoC.
> +      - "renesas,etheravb-r8a7791" for the R8A7791 SoC.
> +      - "renesas,etheravb-r8a7792" for the R8A7792 SoC.
> +      - "renesas,etheravb-r8a7793" for the R8A7793 SoC.
> +      - "renesas,etheravb-r8a7794" for the R8A7794 SoC.
> +      - "renesas,etheravb-rcar-gen2" as a fallback for the above
> +		R-Car Gen2 and RZ/G1 devices.
>
> -	      When compatible with the generic version, nodes must list the
> -	      SoC-specific version corresponding to the platform first
> -	      followed by the generic version.
> +      - "renesas,etheravb-r8a7795" for the R8A7795 SoC.
> +      - "renesas,etheravb-r8a7796" for the R8A7796 SoC.

    Neither here.

> +      - "renesas,etheravb-rcar-gen3" as a fallback for the above
> +		R-Car Gen3 devices.
> +
> +	When compatible with the generic version, nodes must list the
> +	SoC-specific version corresponding to the platform first followed by
> +	the generic version.
>
>  - reg: offset and length of (1) the register block and (2) the stream buffer.
>  - interrupts: A list of interrupt-specifiers, one for each entry in

WBR, Sergei