netdev - Re: [PATCH v2] dt-bindings: net: ravb : Add support for r8a7743 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <afe04380-840a-c282-2f53-40d891e6400a@cogentembedded.com>
Date:   Tue, 11 Jul 2017 15:55:57 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Chris Paterson <Chris.Paterson2@...esas.com>,
        Biju Das <biju.das@...renesas.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Russell King <linux@...linux.org.uk>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Simon Horman <horms@...ge.net.au>,
        Magnus Damm <magnus.damm@...il.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH v2] dt-bindings: net: ravb : Add support for r8a7743 SoC

On 07/11/2017 03:20 PM, Chris Paterson wrote:

>>> Add a new compatible string for the RZ/G1M (R8A7743) SoC.
>>>
>>> Signed-off-by: Biju Das <biju.das@...renesas.com>
>>> ---
>>> v1->v2
>>> * Changed the subject
>>> * re-formatted the required properties
>>>
>>>  .../devicetree/bindings/net/renesas,ravb.txt       | 29 +++++++++++++------
>> ---
>>>  1 file changed, 17 insertions(+), 12 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt
>>> b/Documentation/devicetree/bindings/net/renesas,ravb.txt
>>> index b519503..4717bc2 100644
>>> --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
>>> +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
>>> @@ -4,19 +4,24 @@ This file provides information on what the device
>>> node for the Ethernet AVB  interface contains.
>>>
>>>  Required properties:
>>> -- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790
>> SoC.
>>> -	      "renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC.
>>> -	      "renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC.
>>> -	      "renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC.
>>> -	      "renesas,etheravb-r8a7794" if the device is a part of R8A7794 SoC.
>>> -	      "renesas,etheravb-r8a7795" if the device is a part of R8A7795 SoC.
>>> -	      "renesas,etheravb-r8a7796" if the device is a part of R8A7796 SoC.
>>> -	      "renesas,etheravb-rcar-gen2" for generic R-Car Gen 2 compatible
>> interface.
>>> -	      "renesas,etheravb-rcar-gen3" for generic R-Car Gen 3 compatible
>> interface.
>>> +- compatible: Must contain one or more of the following:
>>
>>     No, it can't contain more than one SoC specific value.
>
> Surely it can contain both "renesas,etheravb-r8a7743" and "renesas,etheravb-rcar-gen2" for example?
>
> As indeed dictated by the instruction further down:

    Yes. Sorry, I should have been more attentive.

>>> +	When compatible with the generic version, nodes must list the
>>> +	SoC-specific version corresponding to the platform first followed by
>>> +	the generic version.

> Kind regards, Chris

MBR, Sergei